Decouple SparkSubmitOperator resumable deployment backends for better…#68679
Open
onlyarnav wants to merge 6 commits into
Open
Decouple SparkSubmitOperator resumable deployment backends for better…#68679onlyarnav wants to merge 6 commits into
onlyarnav wants to merge 6 commits into
Conversation
… maintainability The ResumableJobMixin implementation for SparkSubmitOperator previously had YARN, Kubernetes, and Standalone backend logics interleaved directly inside each mixin method. This scattered per-backend logic across multiple methods. Decoupling these by introducing specialized strategy classes per backend isolates the deployment-specific details, making the operator easier to maintain and extend.
Contributor
Author
|
@SameerMesiah97 could you review the new PR please. |
Contributor
Okay. But for future reference, it is better to revise the existing PR as previous feedback is easier to trace. |
SameerMesiah97
left a comment
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
The use of private classes fixed my main concern. And looking at your comment in the closed PR #68543, it seems like it is plausible that additional backends may be added in the near future so the class-based approach is defensible.
This is basically a lift and shift of much of the existing operator logic and into these classes. So I checked if any bugs were introduced by accident and could not find any. There is a CI failure so I would fix that. No further reservations.
…eclaration self.__backend: _SparkSubmitDeploymentBackend | None = None in __init__ gives mypy the type — fixes error 1. backend: _SparkSubmitDeploymentBackend before the if/elif/else — fixes errors 2 and 3. hasattr check replaced with is not None — fixes the name mangling bug.
Removed unnecessary blank lines in the SparkSubmitOperator and backend classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ResumableJobMixinimplementation forSparkSubmitOperatorpreviously had YARN, Kubernetes, and Standalone backend logics interleaved directly inside each mixin method. This scattered per-backend logic across multiple methods. Decoupling these by introducing specialized strategy classes per backend isolates the deployment-specific details, making the operator easier to maintain and extend.This refactor:
_SparkSubmitDeploymentBackend,_KubernetesSparkSubmitBackend,_YarnSparkSubmitBackend,_StandaloneSparkSubmitBackend) to cleanly isolate the status and execution tracking logic of each deployment mode._backendcached property onSparkSubmitOperator.submit_job,get_job_status,is_job_active,is_job_succeeded,poll_until_complete,on_kill) directly to the active backend strategy.This improves maintainability while keeping public namespaces completely clean.
fixes #68505
Was generative AI tooling used to co-author this PR?